On modular spaces